Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-swp module cleanup #2510

Merged
merged 6 commits into from
Aug 21, 2024
Merged

net-swp module cleanup #2510

merged 6 commits into from
Aug 21, 2024

Conversation

sruffilli
Copy link
Collaborator

@sruffilli sruffilli commented Aug 21, 2024 •
edited
Loading

Fixes #2434

  • Add service-attachment management
  • Variables cleanup (WONTFIX)
  • Better documentation (e.g. proxy subnet requirement, cloud router handling)

@sruffilli
Copy link
Collaborator Author

sruffilli commented Aug 21, 2024 •
edited
Loading

Variables cleanup (namely making address optional) is blocked by upstream hashicorp/terraform-provider-google#19196

@sruffilli sruffilli marked this pull request as ready for review August 21, 2024 09:12
@ludoo ludoo changed the title net-swp cleanup net-swp module cleanup Aug 21, 2024
ludoo
ludoo approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending check on multiple nat subnets as we discussed 👍

@sruffilli sruffilli merged commit e82cc35 into master Aug 21, 2024
18 checks passed
@sruffilli sruffilli deleted the sruffilli/net-swp-cleanup branch August 21, 2024 09:28
@sruffilli
Copy link
Collaborator Author

pending check on multiple nat subnets as we discussed 👍

Multiple nat subnets are indeed allowed and supported, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

net-swp cleanup
2 participants
@sruffilli @ludoo