Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in documentation #2344

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

albertogeniola
Copy link
Contributor

@albertogeniola albertogeniola commented Jun 5, 2024

Minor docs update.

Networking stages A and B will create three projects at least (dev/prod/landing). In case of manual BA binding, users will need to do that on three projects and not two, as currently expressed in the docs.


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files -> no terraform file was edited.
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass -> no terraform file was edited, only README updated

juliocc
juliocc previously requested changes Jun 5, 2024
@ludoo ludoo enabled auto-merge (squash) June 7, 2024 14:21
@ludoo ludoo dismissed juliocc’s stale review June 7, 2024 14:22

implemented change

@ludoo ludoo merged commit 67754ca into GoogleCloudPlatform:master Jun 7, 2024
9 checks passed
albertogeniola added a commit to albertogeniola/cloud-foundation-fabric that referenced this pull request Jun 19, 2024
* Fix typos in documentation

* use toc

---------

Co-authored-by: Alberto Geniola <[email protected]>
Co-authored-by: Ludo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants