Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change shebang on pre-commit checks #2343

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

albertogeniola
Copy link
Contributor

Addresses # 2342

Changes: updates the shebang for the pre-commit hook, specifically pre-commit-tfdocs.sh, so that bash is taken from $PATH and not hardcoded.

export PATH="/opt/homebrew/bin/bash:$PATH" # This makes our bash version to be selected by the shebang
git commit -m "My great commit!"  # This will trigger the pre-hook using the injected bash version into env

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files -> Not needed, no TF file was touched/created
  • Regenerated the relevant README.md files using tools/tfdoc.py -> Not needed, no doc file was touched/created
  • Made sure all relevant tests pass -> Tested working by issuing a simple commit on a TF file

@juliocc juliocc merged commit 61737c4 into GoogleCloudPlatform:master Jun 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on:tools New or changed tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants