-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added force_destroy to dns module #2202
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @nika-pr!
Left one small comment below
Regarding this error. This could happen if you're missing Does installing |
It's not ;) AFAIK you don't need pytest-xdist unless you're passing |
hmmmm do we really need it? edit: I don't much like forcing pytest behaviour on users... |
We can remove that, but then users running e2e tests needs to add As running E2E is niche as of now, this can be removed, but i prefer stuff to just work by default. |
Yes it did, alls DNS module tests passed :) |
Head branch was pushed to by a user without write access
force_destroy was missing from the DNS module, so I added it.
Checklist
If applicable, I acknowledge that I have:
terraform fmt
on all modified filestools/tfdoc.py
Outdated:
When I execute
pytest -k 'modules and dns:' tests/examples
,I am getting
pytest: error: unrecognized arguments: --dist
.I am using Python
3.10.12
and pytest8.1.1
on WSL.