Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align resource names in FAST networking stages #2115

Merged
merged 12 commits into from
Feb 29, 2024

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Feb 28, 2024

This PR aligns resource names in FAST networking stages c/d/e, so that transitioning from one stage to a different one can be done with minimal pain. This is already possible for a/b stages, but not for the other ones.

  • c-nva
  • d-separate-envs
  • e-nva-bgp

@ludoo ludoo requested a review from juliocc February 28, 2024 12:50
@ludoo ludoo marked this pull request as ready for review February 28, 2024 12:50
@ludoo ludoo enabled auto-merge (squash) February 28, 2024 12:50
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left one small comment

@ludoo ludoo merged commit 3972eb6 into master Feb 29, 2024
10 checks passed
@ludoo ludoo deleted the ludo/fast-net-align-stage-names branch February 29, 2024 06:45
@ludoo ludoo added the incompatible change Pull request that breaks compatibility with previous version label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible change Pull request that breaks compatibility with previous version on:FAST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants