-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow granting network user role on host project from project module and factory #1930
Conversation
…ore granular Shared VPC configuration
wow you're fast :) |
Not that fast.. I started workingon this yesterday! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Simo, thanks for this. Dropped a few comments mainly on variable naming and the README wording, once those are addressed this is good to go from my PoV.
Thanks for the feedback and comments, I updated the PR with your improvements! WRT what you suggested I just kept the reference example for the Shared VPC being, IMHO, the best configuration which suits most of the use cases. WDYT? |
I don't think it's a reference as I wrote twice :) I would just move the org policy to the project-level IAM example, and scrap the last example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Simo!!!
This PR updates Shared VPC config for project factory and project module for fine grained Shared VPC configuration. It adds the following attributes to shared_vpc_service_config variable:
It update project module documentation adding reference for Shared VPC configuration (IAM permissions assigned at subnet level + org policy for restricting subnets available on the newly created project). It provides example usage of the new attributes in 2 examples (with new test cases).
Fixes #1929
This PR
I applicable, I acknowledge that I have:
terraform fmt
on all modified filestools/tfdoc.py