Add support for service_external_ips_config to GKE cluster modules
#1925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliocc
requested changes
Dec 13, 2023
luigi-bitonti
force-pushed
the
gke_module
branch
from
0cd1fd4 to
b194ded
Compare
juliocc
requested changes
Dec 15, 2023
| @@ -110,6 +110,9 @@ resource "google_container_cluster" "cluster" { | |||
| enabled = var.backup_configs.enable_backup_agent | |||
| } | |||
| } | |||
| service_external_ips_config { | |||
There was a problem hiding this comment.
Make the block dynamic like (see the surrounding blocks)
luigi-bitonti
force-pushed
the
gke_module
branch
9 times, most recently
from
8da6930 to
77fed17
Compare
ludoo
changed the title
service_external_ips_config to GKE cluster modules
ludoo
changed the title
service_external_ips_config to GKE cluster modulesservice_external_ips_config to GKE cluster modules
ludoo
previously approved these changes
Dec 27, 2023
luigi-bitonti
force-pushed
the
gke_module
branch
from
77fed17 to
9269d74
Compare
luigi-bitonti
force-pushed
the
gke_module
branch
from
9269d74 to
3a0422f
Compare
|
@luigi-bitonti I'm closing this. Feel free to reopen if you want to address the comments above |
Hi Julio, I opened this PR with the changes you requested (dynamic block): #1970 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variable
service_external_ips_configwas added to GKE Autopilot and Standard module.Checklist
I applicable, I acknowledge that I have:
terraform fmton all modified filestools/tfdoc.py