Use TFTEST_E2E_ instead of TF_VAR variables #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use of TF_VAR variables modified results of `tests/examples` and required setting different environment to run `tests/examples` and `tests/examples_e2e` tests. No both can be run using the same environment.
wiktorn
force-pushed
the
wiktorn-e2e-setup-fixes
branch
from
8bb3685 to
3557ed8
Compare
|
@wiktorn I'll try to bring up an env for myself today. After that I'll review this PR. |
juliocc
reviewed
Nov 30, 2023
juliocc
approved these changes
Nov 30, 2023
wiktorn
force-pushed
the
wiktorn-e2e-setup-fixes
branch
from
9b6d1c2 to
6d68b50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of TF_VAR variables modified results of
tests/examplesand required setting different environment to runtests/examplesandtests/examples_e2etests. Now both can be run using the same environment.Checklist
I applicable, I acknowledge that I have:
terraform fmton all modified filestools/tfdoc.py