-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/dlpagent #1868
Fix/dlpagent #1868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you need to have DLP service agent force-created, add to service-agents.yaml:
jit: true
For DLP. Also, bare in mind, that services force-created may miss their role, in this case it will be roles/dlp.serviceAgent
, so this is not a perfect solution.
Thanks, I have removed the explicit identity creation block and have set jit as true . I guess , we can assign the service agent role if required once agent is available. |
Yes, we have this documented here Can you add DLP there too? Thanks. |
@ddaluka There was still one blueprint tests that were failing due to this change, will you be able to fix that, or shall I help you with that? |
Thanks. I have fixed the issue |
Thank you for fixing those ❤️ |
When DLP API service is enabled for a project, we also need its service agent to be available for further IAM roles assignment.
dlp.googleapis.com API supports the identity creation using gcloud beta services identity create --service dlp.googleapis.com
Checklist
I applicable, I acknowledge that I have:
terraform fmt
on all modified filestools/tfdoc.py