Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce mandatory types in all variables #1737

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Enforce mandatory types in all variables #1737

merged 1 commit into from
Oct 6, 2023

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Oct 6, 2023

Update check_documentation.py to ensure all variables have a type.

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@juliocc juliocc requested a review from ludoo October 6, 2023 09:24
@github-actions github-actions bot added on:tools New or changed tool on:modules labels Oct 6, 2023
@juliocc juliocc enabled auto-merge (squash) October 6, 2023 09:29
@juliocc juliocc merged commit ef290c1 into master Oct 6, 2023
@juliocc juliocc deleted the jccb/mandatory-types branch October 6, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorn wiktorn wiktorn approved these changes

@ludoo ludoo Awaiting requested review from ludoo

Assignees
No one assigned
Labels
on:modules on:tools New or changed tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliocc @wiktorn