autodq parsing proposal #1556
Merged
autodq parsing proposal #1556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is simpler for the user. I'm fine with this approach. Some cons of the approach is that it feels a bit magical and also allow end users to mix casing in their spec. Perhaps I'd still keep the input type as an object. This is because we may want to expand this in the future to allow users to supply an additional file containing default values for variables like ignore_null, row_filters, threshold, etc... as well as a collection of rule templates that they can use in the spec. |
ludoo
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@thinhha this is how I'd handle the cameCase/snake_case fields in the spec files. Basically first try cameCase and if it fails then you try snake_case. What do you think?
@ludoo wdyt?