HA VPN over Interconnect modules and blueprint #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliocc
reviewed
May 25, 2023
There was a problem hiding this comment.
Very nice.
I did a quick pass before getting into details.Just a couple of comments for now:
- We're trying to move away from
try()as it tends to hide errors. I'd rather see a combination or non-nullable variables and default values instead of a bunch oftry()calls. - can i haz tests?
juliocc
reviewed
May 30, 2023
sruffilli
changed the title
juliocc
approved these changes
May 31, 2023
ludoo
reviewed
May 31, 2023
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new modules,
net-ipsec-over-interconnectto establish HA VPN over existing VLAN attachments, andnet-dedicated-vlan-attachmentto create (optionally encrypted) vlan attachments, as well as theha-vpn-over-interconnectblueprint that shows how to compose such modules to create a 99.9% encrypted interconnect.