Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network Dashboard improvements and bug fixing #1289

Merged
merged 4 commits into from
Mar 29, 2023

Conversation

simonebruzzechesse
Copy link
Collaborator

  • add explicit requirements for Python version at least 3.9
  • add constraint on Shared VPC service projects and host project to both be in the monitoring scope
  • fix issue with itertools.groupby which assumes the iterator to be already sorted when grouping by keys

The latter issue was causing duplicated metric to be written on Cloud Monitoring resulting in the following error:

One or more TimeSeries could not be written: One or more points were written more frequently than the maximum sampling period configured for the metric

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what you're changing with the groupings, but I trust you :)

@ludoo ludoo added the incompatible change Pull request that breaks compatibility with previous version label Mar 29, 2023
@juliocc
Copy link
Collaborator

juliocc commented Mar 29, 2023

@simonebruzzechesse I'm trying to target Python 3.10 for everything in the repo. Would that make sense for you?

@simonebruzzechesse
Copy link
Collaborator Author

@simonebruzzechesse I'm trying to target Python 3.10 for everything in the repo. Would that make sense for you?

Sure! Function code works with Python 3.10 (tested both locally and on CF), should I explicitly pin the required version in README or is it fine >= 3.10?

@simonebruzzechesse simonebruzzechesse marked this pull request as ready for review March 29, 2023 09:01
@juliocc
Copy link
Collaborator

juliocc commented Mar 29, 2023

@simonebruzzechesse I'm trying to target Python 3.10 for everything in the repo. Would that make sense for you?

Sure! Function code works with Python 3.10 (tested both locally and on CF), should I explicitly pin the required version in README or is it fine >= 3.10?

>= 3.10 sounds good, but whatever you prefer.

@simonebruzzechesse simonebruzzechesse merged commit 94bf7bd into master Mar 29, 2023
@simonebruzzechesse simonebruzzechesse deleted the bruzz/network-dashboard-fixes branch March 29, 2023 12:54
lcaggio pushed a commit that referenced this pull request May 5, 2023
* update documentation and fix group by issue causing duplicated metric
* fix format md
* fix toc indentation
* update required python version in README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible change Pull request that breaks compatibility with previous version on:blueprints
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants