Fixed connection tracking configuration on LB backend in net-ilb module #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cking conf for backends
ludoo
reviewed
Mar 10, 2023
ludoo
reviewed
Mar 10, 2023
ludoo
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per documentation the tracking_mode argument in the connection_tracking section of the backend_service_config supports PER_SESSION or PER_CONNECTION, instead we were passing a boolean value through the track_per_session variable and this was resulting in an error. We could also update the logic and set the tracking_mode value to PER_SESSION when track_per_session was true but updating the variable to tracking_mode seems to be a more general solution for this case.