CloudSQL Backup Configuration: Support Point In Time Recovery #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliocc
requested changes
Feb 7, 2023
juliocc
approved these changes
Feb 9, 2023
|
@tacchino thanks for this PR. Can you rebase and merge? |
Addition of new parameters will be backwards compatible Better reflects the underlying resource requirements
Mark not nullable
|
@juliocc up to date with master now. let me know if I didn't get that right |
|
All good, thanks @tacchino! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the point_in_time_recovery_enabled property in CloudSQL backup_configuration
Use optional() for configuration map in order to maintain backwards compatibility with previous configurations