Feature - CloudSQL pre-allocation private IP range and GKE Cluster ignore_change lifecycle hook. #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
December 13, 2022 17:03
…-foundation-fabric into feature/cts-changes
FAST: add instructions for billing export to stage 0 README (GoogleCloudPlatform#1051) See merge request nwmworld/nwm-digital/modules/third-party/cloud-foundation-fabric!1
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
ludoo
reviewed
Dec 19, 2022
added 4 commits
December 19, 2022 19:07
Refactor as per suggestions in PR See merge request nwmworld/nwm-digital/modules/third-party/cloud-foundation-fabric!2
ludoo
reviewed
Dec 19, 2022
ludoo
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add supports for :
CloudSQL - provide an allocated IP range for private access. In some situations organizations have a pre-allocated /24 to be used as the private IP CIDR for CloudSQL instances. The changes in this PR help supply a pre-allocated IP range for the primary and replica instance
GKE-Cluster - The default pool is deleted on initial cluster creation, however the next iteration of plan/ apply using the module looks at changes on boot_disk_kms_key and always attempts to re-create the cluster there by doing a destroy / create of the cluster and nodepool. Addition of the ignore_changes lifecycle hook for the boot_disk_kms_key on the nodepool prevents the cluster re-creation on a subsequent plan / apply.