Skip to content

gke-nodepool taint loop has faulty declaration #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lianatech-teemu-hemmila opened this issue Oct 12, 2023 · 1 comment · Fixed by #1754
Closed

gke-nodepool taint loop has faulty declaration #1749

lianatech-teemu-hemmila opened this issue Oct 12, 2023 · 1 comment · Fixed by #1754

Comments

@lianatech-teemu-hemmila
Copy link

https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/blob/master/modules/gke-nodepool/main.tf#L222

Should be probably taint.value.effect
ludoo added a commit that referenced this issue Oct 12, 2023
@ludoo
Fix typo in GKE nodepool taints
f7a9652 
Fixes #1749
@ludoo ludoo mentioned this issue Oct 12, 2023
Merged
@ludoo
Copy link
Collaborator

ludoo commented Oct 12, 2023

Thanks for spotting this!

ludoo added a commit that referenced this issue Oct 12, 2023
@ludoo
Fix typo in GKE nodepool taints (#1754)
85d2b8b 
* Fix typo in GKE nodepool taints

Fixes #1749

* fix windows taints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typo in GKE nodepool taints GoogleCloudPlatform/cloud-foundation-fabric
2 participants
@ludoo @lianatech-teemu-hemmila