fix: throw exception when connecting to closed Connector #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatgadkar-goog
force-pushed
the
close-connector
branch
from
9f99e6f to
ec4a66b
Compare
rhatgadkar-goog
changed the title
rhatgadkar-goog
force-pushed
the
close-connector
branch
from
ec4a66b to
ee26059
Compare
rhatgadkar-goog
force-pushed
the
close-connector
branch
from
ee26059 to
2a21233
Compare
enocom
reviewed
Apr 17, 2025
jackwotherspoon
changed the title
enocom
approved these changes
Apr 18, 2025
jackwotherspoon
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the AlloyDB fix for GoogleCloudPlatform/cloud-sql-python-connector#1268.
Was able to reproduce the issue when closing the connector in https://github.com/GoogleCloudPlatform/alloydb-python-connector/blob/main/tests/system/test_pg8000_public_ip.py before calling
connect()here.