Cleanup Cloud SQL DB creds for notebook and frontend #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
imreddy13
commented
Mar 6, 2024
•
imreddy13
commented
- Use a k8s secret for DB creds
- Mount k8s secret in volumes for Ray & frontend pods
- Read the mounted secret volume from the Ray job script in the notebook and from the frontend container
- Remove unecessesary DB cred variables from the notebook
- Fix bug with NLP/DLP imports
imreddy13
requested review from
umeshkumhar,
saikat-royc,
hsachdevah and
artemvmin
artemvmin
approved these changes
Mar 6, 2024
bjornsen
reviewed
Mar 6, 2024
imreddy13
changed the title
imreddy13
changed the title
blackzlq
reviewed
Mar 7, 2024
imreddy13
force-pushed
the
fix-nb
branch
2 times, most recently
from
5e0cf29 to
251f37e
Compare
bjornsen
reviewed
Mar 7, 2024
bjornsen
approved these changes
Mar 7, 2024
|
/gcbrun |
blackzlq
approved these changes
Mar 7, 2024
1) Use a k8s secret for DB creds 2) Mount k8s secret in volumes for Ray & frontend pods 3) Read the mounted secret volume from the Ray job script in the notebook and from the frontend container 4) Remove unecessesary DB cred variables from the notebook 5) Fix import bug with NLP/DLP
|
/gcbrun |
1 similar comment
|
/gcbrun |
leroyjb
pushed a commit
to leroyjb/ai-on-gke
that referenced
this pull request
Jan 24, 2025
…form#295) Cleanup Cloud SQL DB creds 1) Use a k8s secret for DB creds 2) Mount k8s secret in volumes for Ray & frontend pods 3) Read the mounted secret volume from the Ray job script in the notebook and from the frontend container 4) Remove unecessesary DB cred variables from the notebook 5) Fix import bug with NLP/DLP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.