Skip to content

Added functionality to write tfvars files #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025
Merged

Added functionality to write tfvars files #143

merged 2 commits into from
Apr 23, 2025

Conversation

arueth
Copy link
Collaborator

@arueth arueth commented Apr 21, 2025

Trying to simplify and codify the configuration of the platform.

@arueth arueth force-pushed the rueth-write-tfvars branch 2 times, most recently from fd620f6 to a2a8a48 Compare April 22, 2025 15:16
@arueth arueth force-pushed the rueth-write-tfvars branch 2 times, most recently from cb3a813 to 180b91e Compare April 22, 2025 17:00
Copy link
Member

@ferrarimarco ferrarimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions.

  • Do we need to update READMEs when instructing users about how to provide variable values?
  • The FL use case scripts adding some values to these config files (ref). Do you also need to refactor that?

@arueth
Copy link
Collaborator Author

arueth commented Apr 23, 2025

A couple of questions.

  • Do we need to update READMEs when instructing users about how to provide variable values?
  • The FL use case scripts adding some values to these config files (ref). Do you also need to refactor that?

So the goal of this is that you can either set all your variables in the tfvars files or you could set them with the TF_VARS environment variables. Once you run initialize all of the configured values would be written to the tfvars files and they become the source of truth, can be version controlled, etc.

I was running into some issues going into the individual Terraservices and trying to run them manually because some of the values were set in various places. This should make it so you can go into any Terraservice and run it manually.

It shouldn't need to be refactored because it will read the values from the tfvars files. We might consider creating a common script for updating configuration values in the tfvars files.

@arueth
Copy link
Collaborator Author

arueth commented Apr 23, 2025

Ideally this same logic would be applied to the _shared_config folders for each use-case as well I just wanted to prototype it for the base/core configuration.

@arueth arueth force-pushed the rueth-write-tfvars branch from 7065090 to 616d87b Compare April 23, 2025 16:35
@arueth arueth merged commit bb480db into main Apr 23, 2025
22 checks passed
@arueth arueth deleted the rueth-write-tfvars branch April 23, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants