Create an SCP benchmark #5260
Create an SCP benchmark #5260
Conversation
…nchmarks=scp --machine_type=e2-micro
…chmarks=scp --machine_type=e2-micro --data_disk_type=pd-ssd --data_disk_size=10
There was a problem hiding this comment.
Wow this is really great! Exactly as we want it!
There are a couple of very minor linter issues, i.e. you don't seem to need to import data and vm_util.
In future, you can lint with the pyink formatter:
pyink --pyink-indentation 2 --pyink-use-majority-quotes --unstable --line-length=80 {file_path}
It's our bad that the documentation for the linter is so hidden. We should float it higher.
copybara-service
bot
merged commit 18cf91b
into
GoogleCloudPlatform:master
|
This is super high-quality code, we are very impressed and very much appreciate your contribution!
Even with your configurations, we can see that the two threads are ~10% different in speed. This means that in-bound and out-bound work are not handled at the same rate. The next part of the puzzle (on our part), will be to understand why this difference exist. Thank you! :)
We don't have a lot of Windows benchmarks, https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/tree/master/perfkitbenchmarker/windows_benchmarks shows the few we have. The rest of the setup should be similar, with the commands being swapped to Windows. If you need a Windows machine, you can create a VM in the GCP console, and then RDP into it using the RDP client (you will have to download an RDP client.) The Windows password is another tricky part: During a run, PKB would have generated a Windows password, and if you need to RDP into that particular machine, you will have to log it via this flag: https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/blob/master/perfkitbenchmarker/windows_virtual_machine.py#L37 |
|
Thank you! @jellyfishcake |
Summary
This PR introduces the initial implementation of the SCP benchmark for Linux as described in issue #5234.
The SCP benchmark measures the time taken to SCP a file between two VMs. The current version focuses on the Linux implementation and is functional, while the Windows implementation will follow in a future PR or updated later in this PR.
Detalis:
scp_benchmark.pyin thelinux_benchmarksdirectory.BENCHMARK_NAMEandBENCHMARK_CONFIGconstants so that the benchmark can be discovered and run by PKB.GetConfig,Prepare,Run, andCleanupfunctions.Testing:
The benchmark was tested on Linux VMs. Example commands and results:
./pkb.py --benchmarks=scp --machine_type=e2-micro --data_disk_type=pd-ssd --data_disk_size=5./pkb.py --benchmarks=scp --machine_type=e2-micro --data_disk_type=pd-ssd --data_disk_size=20 --scp_file_size_gb=8Pending Items:
Seeking feedback! & Thanks again for your helpful guidance on the GHC open source day!