-
Notifications
You must be signed in to change notification settings - Fork 1k
WideRowHandling: spanner to source db IT #2252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WideRowHandling: spanner to source db IT #2252
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2252 +/- ##
============================================
- Coverage 49.19% 49.18% -0.01%
- Complexity 4620 4951 +331
============================================
Files 924 924
Lines 55852 55852
Branches 5998 5998
============================================
- Hits 27475 27472 -3
Misses 26403 26403
- Partials 1974 1977 +3
🚀 New features to boost your workflow:
|
.../java/com/google/cloud/teleport/v2/templates/SpannerToCassandraSourceDbMaxColumnsSizeIT.java
Outdated
Show resolved
Hide resolved
...db/src/test/java/com/google/cloud/teleport/v2/templates/SpannerToSourceDbWideRowBasicIT.java
Outdated
Show resolved
Hide resolved
...-sourcedb/src/test/resources/SpannerToSourceDbWideRowIT/spanner-max-col-cassandra-schema.sql
Outdated
Show resolved
Hide resolved
Hi @VardhanThigle PR comments have been resolved. Please review and rerun the pipeline. |
7131b4a
to
757988d
Compare
* Added allowes Packet Size * Added and remove unwanted Boundry Check
* Added allowes Packet Size * Added and remove unwanted Boundry Check * Added Foxes for Max in Size IT * Added Fixes for max cols * Added 10mb * Added Fixes * Added Fixes * Spotless fixes * Added Fixes * Added FIxes * removed unwanted
6bb351d
to
90d0bbc
Compare
* Wide row rr handling (GoogleCloudPlatform#148) * Resolve Merge Conflict * resolve merge conflict * Wide row rr fixes (GoogleCloudPlatform#155) * Added allowes Packet Size * Added and remove unwanted Boundry Check * IT Resource Exhausted Fixes * Added allowes Packet Size * Added and remove unwanted Boundry Check * Added Foxes for Max in Size IT * Added Fixes for max cols * Added 10mb * Added Fixes * Added Fixes * Spotless fixes * Added Fixes * Added FIxes * removed unwanted * updated the Comments * PR Review comment fixes * rename function * update comments * Added CopyRight Fixes * Removed and Cleanup code (GoogleCloudPlatform#194) * fix checkstyle * fix schema creation for N columns * fix changestream issue * widerow: add missing changes --------- Co-authored-by: pawankashyapollion <[email protected]> Co-authored-by: Taher Lakdawala <[email protected]> Co-authored-by: taherkl <[email protected]>
This PR introduces validation checks to enforce various constraints on table and column creation, ensuring compliance with database limitations.
Changes Implemented
Table Name Length Constraint (1 to 128 characters)
Maximum Columns per Table (1,024)
Column Name Length Constraint (1 to 128 characters)
String Cell Size Constraint (Max 2,621,440 Unicode characters)