replaced property gcpPubsubTopic with gcpPubsubTopicPrefix #170

skumarlabs · 2020-09-17T09:29:39Z

Replaced property name gcpPubsubTopic with gcpPubsubTopicPrefix in DataflowTemplates/v2/cdc-parent/cdc-embedded-connector/src/main/resources/dataflow_cdc.properties

Fixes the PubSub topic name being null as App.java was not able to get gcpPubsubTopicPrefix value

Replaced property name gcpPubsubTopic with gcpPubsubTopicPrefix. Fixes the PubSub topic name being null as App.java was not able to get gcpPubsubTopicPrefix value

google-cla · 2020-09-17T09:29:45Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

skumarlabs · 2020-09-17T09:31:46Z

@googlebot I signed it!

replaced property gcpPubsubTopic with gcpPubsubTopicPrefix

stale · 2020-11-01T16:34:32Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

pabloem · 2020-11-10T23:23:09Z

I'm sorry I missed this. This LGTM.

skumarlabs · 2020-11-11T07:22:21Z

I'm sorry I missed this. This LGTM.

Never mind. The issue was fixed in a later commit.

prathapreddy123 · 2020-12-03T19:15:21Z

@skumarlabs - Can you rebase to latest master version and resubmit the PR

stale · 2021-01-19T00:54:43Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

prathapreddy123 · 2021-01-21T20:13:48Z

@skumarlabs - Can you rebase this branch to latest master?

…lowTemplates

skumarlabs · 2021-01-22T05:17:06Z

@prathapreddy123 done.

stale · 2021-06-11T01:16:15Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

* Wide Row IT for Forward Migration (#170) * Added Missing Datastream Private Connectivity * Review comments fixes (#176) * Move to generic to Base Class * Rename method * Moved Spanner Check to base class * Added Ignore For 5000 Tables * FM code Refactored (#188) * Added FM Low Priority WIde Row Fixws * Added Code Refectored * Code Refecoting Fixes * removed 5K table test fix compilation error * revert changes * Added IT PR Stuck Fixes and Ignore 100MB test as it is holding our Pipeline * removed 100MB flaky test --------- Co-authored-by: taherkl <[email protected]> Co-authored-by: Akash Thawait <[email protected]>

* Wide Row IT for Forward Migration (GoogleCloudPlatform#170) * Added Missing Datastream Private Connectivity * Review comments fixes (GoogleCloudPlatform#176) * Move to generic to Base Class * Rename method * Moved Spanner Check to base class * Added Ignore For 5000 Tables * FM code Refactored (GoogleCloudPlatform#188) * Added FM Low Priority WIde Row Fixws * Added Code Refectored * Code Refecoting Fixes * removed 5K table test fix compilation error * revert changes * Added IT PR Stuck Fixes and Ignore 100MB test as it is holding our Pipeline * removed 100MB flaky test --------- Co-authored-by: taherkl <[email protected]> Co-authored-by: Akash Thawait <[email protected]>

replaced property gcpPubsubTopic with gcpPubsubTopicPrefix

df5f3c7

Replaced property name gcpPubsubTopic with gcpPubsubTopicPrefix. Fixes the PubSub topic name being null as App.java was not able to get gcpPubsubTopicPrefix value

pull-request-size bot added the size/XS label Sep 17, 2020

google-cla bot added the cla: no The PR submitter does not have a CLA label Sep 17, 2020

google-cla bot added cla: yes The PR submitter has a CLA and removed cla: no The PR submitter does not have a CLA labels Sep 17, 2020

skumarlabs and others added 6 commits September 17, 2020 15:18

Merge pull request #1 from skumarlabs/property-name-patch-1

dd01ea1

replaced property gcpPubsubTopic with gcpPubsubTopicPrefix

updated properties file with values

a9f1656

fixed JobInfo NullPointer exception

4d611b5

reverted commit to keep master separate

e5026a0

merge JobInfo NullPointer Exception Fix from prod branch

4a91b07

updated values in properties file

32ddd96

stale bot added the obsolete The PR hasn't had activity in 45 days label Nov 1, 2020

stale bot closed this Nov 9, 2020

pabloem reopened this Nov 10, 2020

stale bot removed the obsolete The PR hasn't had activity in 45 days label Nov 10, 2020

pabloem added the Google LGTM Approval of a pull request to be merged into the repository label Nov 10, 2020

prathapreddy123 removed the Google LGTM Approval of a pull request to be merged into the repository label Dec 3, 2020

stale bot added the obsolete The PR hasn't had activity in 45 days label Jan 19, 2021

prathapreddy123 self-requested a review January 21, 2021 20:13

stale bot removed the obsolete The PR hasn't had activity in 45 days label Jan 21, 2021

prathapreddy123 assigned skumarlabs Jan 21, 2021

Merge branch 'master' of https://github.com/GoogleCloudPlatform/Dataf…

00178b8

…lowTemplates

prathapreddy123 added the Google LGTM Approval of a pull request to be merged into the repository label Jan 30, 2021

prathapreddy123 approved these changes Jan 30, 2021

View reviewed changes

stale bot added the obsolete The PR hasn't had activity in 45 days label Jun 11, 2021

stale bot closed this Jul 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

replaced property gcpPubsubTopic with gcpPubsubTopicPrefix #170

replaced property gcpPubsubTopic with gcpPubsubTopicPrefix #170

Uh oh!

skumarlabs commented Sep 17, 2020

Uh oh!

google-cla bot commented Sep 17, 2020

Uh oh!

skumarlabs commented Sep 17, 2020

Uh oh!

stale bot commented Nov 1, 2020

Uh oh!

pabloem commented Nov 10, 2020

Uh oh!

skumarlabs commented Nov 11, 2020 •

edited

Loading

Uh oh!

prathapreddy123 commented Dec 3, 2020

Uh oh!

stale bot commented Jan 19, 2021

Uh oh!

prathapreddy123 commented Jan 21, 2021

Uh oh!

skumarlabs commented Jan 22, 2021

Uh oh!

stale bot commented Jun 11, 2021

Uh oh!

Uh oh!

replaced property gcpPubsubTopic with gcpPubsubTopicPrefix #170

replaced property gcpPubsubTopic with gcpPubsubTopicPrefix #170

Uh oh!

Conversation

skumarlabs commented Sep 17, 2020

Uh oh!

google-cla bot commented Sep 17, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

skumarlabs commented Sep 17, 2020

Uh oh!

stale bot commented Nov 1, 2020

Uh oh!

pabloem commented Nov 10, 2020

Uh oh!

skumarlabs commented Nov 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

prathapreddy123 commented Dec 3, 2020

Uh oh!

stale bot commented Jan 19, 2021

Uh oh!

prathapreddy123 commented Jan 21, 2021

Uh oh!

skumarlabs commented Jan 22, 2021

Uh oh!

stale bot commented Jun 11, 2021

Uh oh!

Uh oh!

skumarlabs commented Nov 11, 2020 •

edited

Loading