Add parameterized queries support as new Spark options #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
davidrabinowitz
requested changes
Apr 2, 2025
...uery-connector-common/src/main/java/com/google/cloud/spark/bigquery/SparkBigQueryConfig.java
Outdated
Show resolved
Hide resolved
...-connector-common/src/main/java/com/google/cloud/bigquery/connector/common/BigQueryUtil.java
Outdated
Show resolved
Hide resolved
...onnector-common/src/main/java/com/google/cloud/bigquery/connector/common/BigQueryClient.java
Show resolved
Hide resolved
…a top-level class
BoqianShi
force-pushed
the
parameterized_squashed
branch
from
2b61789 to
2977405
Compare
|
/gcbrun |
|
/gcbrun |
BoqianShi
commented
Apr 8, 2025
BoqianShi
commented
Apr 8, 2025
|
|
||
| if (keyLower.startsWith(NAMED_PARAM_PREFIX)) { | ||
| Preconditions.checkArgument( | ||
| currentMode != ParameterMode.POSITIONAL, |
BoqianShi
commented
Apr 8, 2025
| private final ImmutableMap<String, QueryParameterValue> namedParameters; | ||
| private final ImmutableList<QueryParameterValue> positionalParameters; | ||
|
|
||
| public QueryParameterHelper( |
BoqianShi
commented
Apr 8, 2025
...nector-common/src/test/java/com/google/cloud/bigquery/connector/common/BigQueryUtilTest.java
Show resolved
Hide resolved
BoqianShi
commented
Apr 8, 2025
...nector-common/src/test/java/com/google/cloud/bigquery/connector/common/BigQueryUtilTest.java
Show resolved
Hide resolved
BoqianShi
commented
Apr 8, 2025
| }); | ||
|
|
||
| Throwable cause = thrown; | ||
| if (cause instanceof ProvisionException && cause.getCause() != null) { |
There was a problem hiding this comment.
Provision Exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new Spark options (
NamedParameters.<name>,PositionalParameters.<index>) for specifying BigQuery parameterized query arguments, stated in issues/506.Parameters use the
"TYPE:value"string format (e.g.,"STRING:value","INT64:123"). Added validation prevents mixing named/positional parameters and checks format, supported types (explicitly disallowingARRAY/STRUCTfor now), and indices. Includes updated unit and integration tests.