fix: always close file handles to stdout/stderr logs #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/chrome-launcher.ts
Outdated
| if (this.userDataDir === undefined || this.opts.userDataDir !== undefined) { | ||
| return resolve(); | ||
| } | ||
|
|
||
| if (this.outFile) { | ||
| this.fs.closeSync(this.outFile); | ||
| delete this.outFile; |
There was a problem hiding this comment.
Makes sense we should always close these file handles when done. I'm curious though, what was the error you were seeing? EDIT: ah, you filed an issue #260
connorjclark
changed the title
connorjclark
approved these changes
Mar 14, 2022
|
Can you run |
|
@connorjclark done |
|
guys, this still let error file open when used custom data dir, no? i had to create a patch-package which moves the check condition (if we are using custom data dir) bellow the closeSync of errFile to make it work... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should closeSync outFile and errFile when userDataDir is custom.
fixes #260