Add additional chrome flags #227
Conversation
There was a problem hiding this comment.
enable-automation. most of the benefits are great, but the added infobar caused some problems for webplatformtests: web-platform-tests/wpt#6348. thoughts?
Seems like it could be ok, but do we have any tests sensitive enough to window size/positioning that we may get errors like they saw in https://groups.google.com/a/chromium.org/g/platform-predictability/c/k1I70ez7suM/m/1iskWQeKAgAJ ?
running Lighthouse's |
|
element rects and the full-page-screenshot also look properly aligned, so seems ok to me |
on second thought i don't think we want this. i'd take it if it didnt add its own infobar. but i just had a bunch that the infobar mucks with the screenshots and.. indeed it does.
that issue: GoogleChrome/lighthouse#4451 |
extra descriptions of these at https://github.com/GoogleChrome/chrome-launcher/blob/master/docs/chrome-flags-for-tools.md
feels good
disable-component-update.. this is huge, as I don't believedisable-background-networkingwas toggling this off.disable-client-side-phishing-detection. probably not a huge deal, but why not.disable-ipc-flooding-protection. Been default in pptr since 2018. puppeteer/puppeteer@2a88690 seems goodpassword-store=basicanduse-mock-keychain. default in chromedriver/pptr. see links in the markdown.not sure....
enable-automation. most of the benefits are great, but the added infobar caused some problems for webplatformtests: Stop using Chrome's automation extension for testharness tests web-platform-tests/wpt#6348. thoughts?closes #23 (so old. made redundant, finally)