Fixed Transaction.GetInvoiceFromTxn to convert to the right type of Python object #2074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for a GncInvoice.
featherfeet
force-pushed
the
fix-get-invoice-from-transaction-python
branch
from
9d5475b to
479ecc7
Compare
|
@jralls , sorry for the delay. I believe the last "self" argument is not needed. I have added a Python unit test that shows the fixed binding works. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetInvoiceFromTxn method for Transaction objects in the Python bindings binds to a C function that returns a GncInvoice*, but it was attempting to return a Transaction, which causes errors. Fixed it to return a Python Invoice object.