Skip to content

restructure repository and support UPM #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

JoC0de
Copy link
Collaborator

@JoC0de JoC0de commented Jan 9, 2023

restructure repository
add support for UPM

@JoC0de JoC0de linked an issue Jan 9, 2023 that may be closed by this pull request
@JoC0de JoC0de force-pushed the feature/update-project-layout branch 4 times, most recently from cc0741d to 6acbc0c Compare January 10, 2023 23:08
@JoC0de JoC0de force-pushed the feature/update-project-layout branch from 6acbc0c to 0816d2e Compare January 14, 2023 09:13
@JoC0de
Copy link
Collaborator Author

JoC0de commented Jan 14, 2023

@jwittner can you have a short look at the new repository structure (just look at the resulting https://github.com/JoC0de/NuGetForUnity/tree/feature/update-project-layout)?
It is not required to change the repository structure to support UPM, I just wanted to "clean up" the structure because when we support UPM we can't change it (at least the part where the package.json is located).
For easier understanding:

  • src/NuGetForUnity/ is the UPM package, it contains only the code that is needed by the "user"
  • src/NuGetForUnity.Tests/ is the Unity project that contains the tests, it includes NuGetForUnity as a local package.

You can ignore that the GitHub actions on the PR are failing this is just "by design" they are working on https://github.com/JoC0de/NuGetForUnity/ and will work as soon as the PR is merged.

@jwittner
Copy link
Collaborator

Looks reasonable!

@JoC0de
Copy link
Collaborator Author

JoC0de commented Jan 17, 2023

@jwittner Ok thanks for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can NuGetForUnity be installed as a package via PackageManager?
2 participants