Skip to content

Chore: Moved test datasets to s3 #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 10, 2025
Merged

Chore: Moved test datasets to s3 #2109

merged 3 commits into from
Mar 10, 2025

Conversation

kevinmessiaen
Copy link
Member

Description

Moved test datasets to s3

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@kevinmessiaen kevinmessiaen mentioned this pull request Feb 12, 2025
Closed
@kevinmessiaen kevinmessiaen changed the title Moved test datasets to s3 Chore: Moved test datasets to s3 Feb 12, 2025
henchaves
henchaves requested changes Feb 12, 2025
View reviewed changes
Copy link
Member

@henchaves henchaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to move all files that we fetch (from GH giskard-examples and third-party sources) to S3 too

@kevinmessiaen kevinmessiaen requested a review from henchaves March 6, 2025 08:30
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@henchaves henchaves merged commit 92a63b6 into main Mar 10, 2025
19 checks passed
@henchaves henchaves deleted the feature/move-test-data-s3 branch March 10, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henchaves henchaves henchaves approved these changes

@mattbit mattbit Awaiting requested review from mattbit

Assignees

@kevinmessiaen kevinmessiaen

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinmessiaen @henchaves