Skip to content

Fix slack jobs in create-release GH action #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions .github/workflows/create-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,10 @@ jobs:
method: chat.postMessage
token: ${{ secrets.SLACK_BOT_TOKEN }}
payload: |
"channel": "${{ vars.SLACK_CHANNEL_ID }}",
"text": "Release *${{ env.VERSION_NAME }}* is on the way :rocket:
<${{ github.server_url }}/${{ github.actor }}|@${{ github.actor }}> | <${{ github.server_url }}/${{ github.repository }}/commit/${{ github.sha }}|commit> <!channel>"
{
"channel": "${{ vars.SLACK_CHANNEL_ID }}",
"text": "Release *${{ env.VERSION_NAME }}* is on the way :rocket: <${{ github.server_url }}/${{ github.actor }}|@${{ github.actor }}> | <${{ github.server_url }}/${{ github.repository }}/commit/${{ github.sha }}|commit> <!channel>"
}

- name: Configure git
run: |
Expand Down Expand Up @@ -105,7 +106,6 @@ jobs:
echo "JOB_SUCCESS=true" >> $GITHUB_ENV

- name: "@slack Share release process completion"
# cancellable always() https://docs.github.com/en/actions/learn-github-actions/expressions#status-check-functions
if: ${{ !cancelled() }}
uses: slackapi/[email protected]
env:
Expand All @@ -119,7 +119,9 @@ jobs:
method: chat.postMessage
token: ${{ secrets.SLACK_BOT_TOKEN }}
payload: |
"channel": "${{ vars.SLACK_CHANNEL_ID }}",
"text": "${{ env.JOB_SUCCESS == 'true' && env.ON_SUCCESS || env.ON_FAILURE }}",
"thread_ts": "${{ steps.slack.outputs.ts }}",
"reply_broadcast": true
{
"channel": "${{ vars.SLACK_CHANNEL_ID }}",
"text": "${{ env.JOB_SUCCESS == 'true' && env.ON_SUCCESS || env.ON_FAILURE }}",
"thread_ts": "${{ steps.slack.outputs.ts }}",
"reply_broadcast": true
}
Loading