Skip to content

[GSK-3577] Cleanup: Remove hub integration #1944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Sep 3, 2024
Merged

[GSK-3577] Cleanup: Remove hub integration #1944

merged 41 commits into from
Sep 3, 2024

Conversation

kevinmessiaen
Copy link
Member

@kevinmessiaen kevinmessiaen commented May 30, 2024 •
edited by henchaves
Loading

Description

This PR removes all pieces of legacy-hub from giskard project

Related Issue

GSK-3577 (available on Linear)

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@sonarqubecloud SonarQubeCloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 3, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 3, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 3, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@henchaves henchaves requested a review from Alexlandeau June 3, 2024 15:59
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 4, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 4, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@henchaves henchaves changed the title Cleanup: Remove hub integration [GSK-3577] Cleanup: Remove hub integration Jun 4, 2024
@linear Linear
Copy link

linear bot commented Jun 4, 2024

GSK-3577 Refactor giskard lib to remove GiskardClient and MLWorker code

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 4, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud

@henchaves henchaves removed their assignment Jun 24, 2024
@henchaves henchaves self-requested a review June 24, 2024 09:31
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
56.2% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
9.7% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@kevinmessiaen kevinmessiaen merged commit 111941d into main Sep 3, 2024
14 of 16 checks passed
@kevinmessiaen kevinmessiaen deleted the cleanup/remove-hub-integration branch September 3, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henchaves henchaves henchaves approved these changes

@Hartorn Hartorn Awaiting requested review from Hartorn

@Inokinoki Inokinoki Awaiting requested review from Inokinoki

@Alexlandeau Alexlandeau Awaiting requested review from Alexlandeau

Assignees

@kevinmessiaen kevinmessiaen

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinmessiaen @henchaves