fix(uPDP): respect call type camera configuration #1883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes camera configuration handling when video is disabled at the call type level by discarding stored camera preferences and preventing unnecessary permission prompts.
- Conditionally renders video preview components based on call type video settings
- Discards stored camera device preferences when video is disabled at call type level
- Prevents device enumeration and permission prompts when camera is disabled
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sample-apps/react/react-dogfood/components/Lobby.tsx | Conditionally renders VideoPreview only when video is enabled in settings |
| packages/react-sdk/src/hooks/usePersistedDevicePreferences.ts | Modifies camera device handling to respect call type video configuration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Overview
When the camera is disabled on a call type level, we should completely discard any previously stored camera preferences.
Also, we shouldn't prompt for permission (caused by the device listing).