fix: viewer livestream muting issue in SDK #1882
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Overview
This pull request updates the livestream viewer and layout components to improve audio muting and video dimension handling, while simplifying the way livestream calls are rendered in the sample app. The most important changes are grouped below:
Audio Muting Logic Improvements:
ViewerLivestreamControls
component now mutes/unmutes the dominant speaker's audio by adjusting the audio track volume directly, instead of toggling the speakerphone viaInCallManager
. This provides more precise control over audio muting in livestreams. [1] [2] [3]Livestream Layout and Video Dimension Handling:
LivestreamLayout
component now uses a newVideoTrackDimensionsRenderLessComponent
that leverages theuseTrackDimensions
hook to accurately track and update video dimensions for both the presenter (during screen share) and the current speaker. This replaces the previous approach based on call stats reports. [1] [2] [3] [4]objectFit
property onVideoRenderer
has been simplified, and the property is now consistently passed for both presenter and current speaker video tracks. [1] [2]Sample App Simplification:
ViewLiveStreamChildren
component no longer manually creates and manages the call object, and instead directly renders theLivestreamPlayer
component, reducing complexity.