-
Notifications
You must be signed in to change notification settings - Fork 38
feat(react-native): reject call when busy #1856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kristian-mkd
wants to merge
35
commits into
main
Choose a base branch
from
rn-232-busy-tone
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristian-mkd
commented
Jul 22, 2025
sample-apps/react/react-dogfood/components/Ringing/RingingCallNotification.tsx
Outdated
Show resolved
Hide resolved
kristian-mkd
commented
Jul 22, 2025
packages/react-sdk/src/components/RingingCall/RingingCallControls.tsx
Outdated
Show resolved
Hide resolved
santhoshvai
reviewed
Jul 23, 2025
sample-apps/react-native/dogfood/src/components/VideoWrapper.tsx
Outdated
Show resolved
Hide resolved
santhoshvai
reviewed
Jul 23, 2025
packages/react-native-sdk/src/components/Call/CallControls/IncomingCallControls.tsx
Outdated
Show resolved
Hide resolved
santhoshvai
reviewed
Jul 23, 2025
packages/react-native-sdk/src/components/Call/CallControls/IncomingCallControls.tsx
Outdated
Show resolved
Hide resolved
santhoshvai
reviewed
Jul 23, 2025
packages/react-native-sdk/src/components/Call/CallControls/IncomingCallControls.tsx
Outdated
Show resolved
Hide resolved
…omingCallControls.tsx Co-authored-by: Santhosh Vaiyapuri <[email protected]>
oliverlaz
reviewed
Aug 5, 2025
packages/react-native-sdk/src/components/Call/RingingCallContent/RingingCallContent.tsx
Outdated
Show resolved
Hide resolved
santhoshvai
reviewed
Aug 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change absolutely necessary?
it seems like we are informing integrators to handle this on their own to not show incoming call component
santhoshvai
reviewed
Aug 6, 2025
santhoshvai
reviewed
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Overview
Adds support in the react-native SDK for automatically rejecting a call with reason
busy
when the callee is in another call, so that integrators can implement handing of thecallee busy scenario
.📝 Implementation notes
Adds
shouldRejectCallWhenBusy
props in React Native push notifications configuration. (false
by default)Handles the call rejection case in the sample app with:
Call rejected because user is busy.
🎫 Ticket: https://linear.app/stream/issue/RN-232
📑 Docs: https://github.com/GetStream/docs-content/pull/476