fix: sync call state after a failed reconnect #1846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverlaz
requested review from
myandrienko,
santhoshvai,
kristian-mkd and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR ensures client and server call states stay in sync by fetching the latest call data before marking a reconnect as failed.
- Introduces a
markAsReconnectingFailedhelper that callsthis.get()then updates the calling state - Replaces direct
setCallingState(RECONNECTING_FAILED)calls in reconnect failure paths withawait markAsReconnectingFailed()
Comments suppressed due to low confidence (1)
packages/client/src/Call.ts:1361
- Consider adding unit tests to verify that when reconnect fails (e.g., due to an unrecoverable error),
get()is called and the calling state transitions toRECONNECTING_FAILEDas expected.
const markAsReconnectingFailed = async () => {
santhoshvai
approved these changes
Jul 7, 2025
kristian-mkd
approved these changes
Jul 7, 2025
myandrienko
approved these changes
Jul 7, 2025
oliverlaz
added a commit
that referenced
this pull request
Jul 8, 2025
Follow-up to #1846. `call.leave()` throws an error after unrecoverable FAST reconnect. Our "leave" flow requires the client to announce its disconnect from the call to the SFU so the SFU can perform certain state cleanups faster. However, in the case described above, this isn't possible because the new SFU client never successfully connected to the SFU, and the signal WS was never established. This makes it impossible to send the announcement. This PR adds better error handling and doesn't prevent the `call` instance disposal. 🎫 Ticket: https://linear.app/stream/issue/RN-241/refresh-call-state-after-a-failed-reconnect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Overview
When a call reconnect fails because of
unrecoverableerror (typically due to a permission revocation, or call being ended in the meantime), the client-side call state wasn't up-to-date with the server-side one (/joindidn't return any data).📝 Implementation notes
In this PR, before flagging the
callingStateasRECONNECTING_FAILED, we perform an additional request to our backend so we can synchronize both states.🎫 Ticket: https://linear.app/stream/issue/RN-241/refresh-call-state-after-a-failed-reconnect