feat: move audio route manager inside SDK #1840
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/react-native-sdk/src/components/Call/CallContent/CallContent.tsx # sample-apps/react-native/dogfood/ios/Podfile.lock
# Conflicts: # sample-apps/react-native/dogfood/ios/Podfile.lock
# Conflicts: # sample-apps/react-native/dogfood/ios/Podfile.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Overview
For both Android and iOS, we remove the in-call manager dependency and make a similar module inside the SDK
TODO
📝 Implementation notes
Android
If user selects nothing..
and passes start("video). we choose based on this prio wired headset => BT -> speaker -> earpiece
if passes("audio"), we choose based on this prio wired headset => BT -> earpiece -> speaker (meant for audio only phone calls, almost never used)
2. If user selects something.. we stick to that device.. unless that device is unplugged, when unplugged we revert to
iOS
TODO
Ref: #1829
🎫 Ticket: https://linear.app/stream/issue/XYZ-123
📑 Docs: https://github.com/GetStream/docs-content/pull/