fix: properly delete drafts with quoted messages #1573
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
This PR fixes an issue where
draft
s containing aquotedMessage
were never cleared from themessageComposer
state unless manually deleted.The easiest way to reproduce this is to:
draft
that contains a quoted messageThe reason this happens is this check, which is used to determine whether a draft should be deleted on pretty much all
state
listeners in themessageComposer
, like so.However, since we're doing
messageComposer.clear()
every time we send a message the composite invocation never clears the quoted message state whenever that happens (as seen here and then here).This in turn causes
channel.deleteDraft
to never be invoked hence the bug.Changelog