fix: broken api return values and types #1550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isekovanic
requested review from
vishalnarkhede,
santhoshvai,
khushal87,
szuperaz,
oliverlaz,
arnautov-anton,
MartinCupela and
myandrienko
as code owners
|
Size Change: +861 B (+0.21%) Total Size: 409 kB
|
isekovanic
commented
May 28, 2025
|
|
||
| // Vitest helper (serialized errors are too large to read) | ||
| // https://github.com/vitest-dev/vitest/blob/v3.1.3/packages/utils/src/error.ts#L60-L62 | ||
| toJSON() { |
There was a problem hiding this comment.
This was copied over from Anton's serialization of API errors for the purposes of getting it out quickly so that the LLC doesn't have broken types.
We can enrich and revisit these offline specific errors later on and use them as needed.
oliverlaz
approved these changes
May 28, 2025
MartinCupela
approved these changes
May 28, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 28, 2025
## [9.3.0](v9.2.0...v9.3.0) (2025-05-28) ### Bug Fixes * broken api return values and types ([#1550](#1550)) ([07a204c](07a204c)) * override target scalar, null and undefined values with mergeWith ([#1549](#1549)) ([ad3a328](ad3a328)) ### Features * [CHA-858] Add event hooks to app settings ([#1537](#1537)) ([4612572](4612572))
|
🎉 This PR is included in version 9.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
Unfortunately, with the latest offline support rework the types of all queueable actions were broken to be
T | undefinedinstead ofT.This PR addresses that, by forcing
queueTaskto throw if execution fails just like any of our HTTP apis would.Changelog