Fix v15/renaming const variables names #123
Conversation
BREAKING CHANGE: absl::optional has been replaced by std::optional
…ith those of included projects. BREAKING CHANGE: Added explicit constructors on all single-argument constructors.
…l-with-std-optional fix(Optional): use std::optional
…s into fix/explicit_keyword_on_point_and_vector
BREAKING CHANGE: absl::string_view has been replaced by std::string_view
…:Geode-solutions/OpenGeode-Geosciences into fix_v15/solid_mesh_missing_include_and_bitsery_git_tag_change
…ng_include_and_bitsery_git_tag_change fix(ABI): update ABI
…ariable name convention)
…view-with-std fix(StringView): use std::string_view
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -23,6 +23,8 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <optional> | |||
There was a problem hiding this comment.
warning: 'optional' file not found [clang-diagnostic-error]
#include <optional>
^| @@ -23,6 +23,8 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <optional> | |||
There was a problem hiding this comment.
warning: 'optional' file not found [clang-diagnostic-error]
#include <optional>
^| @@ -23,6 +23,8 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <optional> | |||
There was a problem hiding this comment.
warning: 'optional' file not found [clang-diagnostic-error]
#include <optional>
^| @@ -23,6 +23,8 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <optional> | |||
There was a problem hiding this comment.
warning: 'optional' file not found [clang-diagnostic-error]
#include <optional>
^…in python bindings)
fix(OpenGeode): update to new AABBTree api
| @@ -23,7 +23,7 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <absl/strings/string_view.h> | |||
| #include <string_view> | |||
There was a problem hiding this comment.
warning: 'string_view' file not found [clang-diagnostic-error]
#include <string_view>
^| @@ -24,10 +24,9 @@ | |||
| #pragma once | |||
|
|
|||
| #include <string> | |||
There was a problem hiding this comment.
warning: 'string' file not found [clang-diagnostic-error]
#include <string>
^| @@ -23,7 +23,7 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <absl/strings/string_view.h> | |||
| #include <string_view> | |||
There was a problem hiding this comment.
warning: 'string_view' file not found [clang-diagnostic-error]
#include <string_view>
^| @@ -24,10 +24,9 @@ | |||
| #pragma once | |||
|
|
|||
| #include <string> | |||
There was a problem hiding this comment.
warning: 'string' file not found [clang-diagnostic-error]
#include <string>
^| @@ -23,7 +23,7 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <absl/strings/string_view.h> | |||
| #include <string_view> | |||
There was a problem hiding this comment.
warning: 'string_view' file not found [clang-diagnostic-error]
#include <string_view>
^| @@ -24,7 +24,7 @@ | |||
| #include <geode/geosciences/explicit/representation/io/cross_section_input.h> | |||
|
|
|||
| #include <absl/strings/str_cat.h> | |||
| #include <absl/strings/string_view.h> | |||
| #include <string_view> | |||
|
|
|||
There was a problem hiding this comment.
warning: included header string_view is not used directly [misc-include-cleaner]
| @@ -24,10 +24,9 @@ | |||
| #include <geode/geosciences/explicit/representation/io/cross_section_output.h> | |||
There was a problem hiding this comment.
warning: 'geode/geosciences/explicit/representation/io/cross_section_output.h' file not found [clang-diagnostic-error]
#include <geode/geosciences/explicit/representation/io/cross_section_output.h>
^| @@ -24,10 +24,9 @@ | |||
| #include <geode/geosciences/explicit/representation/io/cross_section_output.h> | |||
|
|
|||
| #include <string> | |||
| #include <string_view> | |||
| #include <vector> | |||
There was a problem hiding this comment.
warning: included header string_view is not used directly [misc-include-cleaner]
| #include <vector> | |
| #include <vector> |
| @@ -39,7 +38,7 @@ | |||
| namespace geode | |||
| { | |||
| std::vector< std::string > save_cross_section( | |||
| const CrossSection& cross_section, absl::string_view filename ) | |||
| const CrossSection& cross_section, std::string_view filename ) | |||
There was a problem hiding this comment.
warning: 2 adjacent parameters of 'save_cross_section' of similar type are easily swapped by mistake [bugprone-easily-swappable-parameters]
const CrossSection& cross_section, std::string_view filename )
^Additional context
src/geode/geosciences/explicit/representation/io/cross_section_output.cpp:40: the first parameter in the range is 'cross_section'
const CrossSection& cross_section, std::string_view filename )
^src/geode/geosciences/explicit/representation/io/cross_section_output.cpp:40: the last parameter in the range is 'filename'
const CrossSection& cross_section, std::string_view filename )
^src/geode/geosciences/explicit/representation/io/cross_section_output.cpp:40: 'const int &' and 'int' parameters accept and bind the same kind of values
const CrossSection& cross_section, std::string_view filename )
^| @@ -59,7 +58,7 @@ | |||
| } | |||
|
|
|||
| bool is_cross_section_saveable( | |||
| const CrossSection& cross_section, absl::string_view filename ) | |||
| const CrossSection& cross_section, std::string_view filename ) | |||
There was a problem hiding this comment.
warning: 2 adjacent parameters of 'is_cross_section_saveable' of similar type are easily swapped by mistake [bugprone-easily-swappable-parameters]
const CrossSection& cross_section, std::string_view filename )
^Additional context
src/geode/geosciences/explicit/representation/io/cross_section_output.cpp:60: the first parameter in the range is 'cross_section'
const CrossSection& cross_section, std::string_view filename )
^src/geode/geosciences/explicit/representation/io/cross_section_output.cpp:60: the last parameter in the range is 'filename'
const CrossSection& cross_section, std::string_view filename )
^src/geode/geosciences/explicit/representation/io/cross_section_output.cpp:60: 'const int &' and 'int' parameters accept and bind the same kind of values
const CrossSection& cross_section, std::string_view filename )
^fix(OpenGeode): update to new ABI
fix(Filesystem): upgrading to standard filesystem
| @@ -23,13 +23,12 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <filesystem> | |||
There was a problem hiding this comment.
warning: 'filesystem' file not found [clang-diagnostic-error]
#include <filesystem>
^| @@ -23,8 +23,9 @@ | |||
|
|
|||
| #include <geode/geosciences/explicit/representation/io/structural_model_input.h> | |||
There was a problem hiding this comment.
warning: 'geode/geosciences/explicit/representation/io/structural_model_input.h' file not found [clang-diagnostic-error]
#include <geode/geosciences/explicit/representation/io/structural_model_input.h>
^| @@ -23,8 +23,9 @@ | |||
|
|
|||
| #include <geode/geosciences/explicit/representation/io/structural_model_input.h> | |||
|
|
|||
| #include <string_view> | |||
|
|
|||
There was a problem hiding this comment.
warning: included header string_view is not used directly [misc-include-cleaner]
| @@ -24,10 +24,9 @@ | |||
| #include <geode/geosciences/explicit/representation/io/structural_model_output.h> | |||
There was a problem hiding this comment.
warning: 'geode/geosciences/explicit/representation/io/structural_model_output.h' file not found [clang-diagnostic-error]
#include <geode/geosciences/explicit/representation/io/structural_model_output.h>
^| @@ -24,10 +24,9 @@ | |||
| #include <geode/geosciences/explicit/representation/io/structural_model_output.h> | |||
|
|
|||
| #include <string> | |||
| #include <string_view> | |||
| #include <vector> | |||
There was a problem hiding this comment.
warning: included header string_view is not used directly [misc-include-cleaner]
| #include <vector> | |
| #include <vector> |
| @@ -23,13 +23,13 @@ | |||
|
|
|||
| #include <geode/geosciences/implicit/representation/io/geode/geode_implicit_structural_model_output.h> | |||
|
|
|||
| #include <filesystem> | |||
| #include <fstream> | |||
There was a problem hiding this comment.
warning: included header filesystem is not used directly [misc-include-cleaner]
| #include <fstream> | |
| #include <fstream> |
| @@ -23,13 +23,13 @@ | |||
|
|
|||
| #include <geode/geosciences/implicit/representation/io/geode/geode_implicit_structural_model_output.h> | |||
|
|
|||
| #include <filesystem> | |||
| #include <fstream> | |||
| #include <string> | |||
There was a problem hiding this comment.
warning: included header fstream is not used directly [misc-include-cleaner]
| #include <string> | |
| #include <string> |
| @@ -23,8 +23,9 @@ | |||
|
|
|||
| #include <geode/geosciences/implicit/representation/io/horizons_stack_input.h> | |||
There was a problem hiding this comment.
warning: 'geode/geosciences/implicit/representation/io/horizons_stack_input.h' file not found [clang-diagnostic-error]
#include <geode/geosciences/implicit/representation/io/horizons_stack_input.h>
^| { | ||
| const auto input = detail::geode_object_input_reader< | ||
| HorizonsStackInputFactory< dimension > >( filename ); | ||
| return input->is_loadable(); | ||
| } | ||
|
|
||
| template HorizonsStack< 2 > opengeode_geosciences_implicit_api | ||
| load_horizons_stack( absl::string_view ); | ||
| load_horizons_stack( std::string_view ); |
There was a problem hiding this comment.
warning: variable 'string_view' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
load_horizons_stack( std::string_view );
^| template HorizonsStack< 3 > opengeode_geosciences_implicit_api | ||
| load_horizons_stack( absl::string_view ); | ||
| load_horizons_stack( std::string_view ); |
There was a problem hiding this comment.
warning: variable 'string_view' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
load_horizons_stack( std::string_view );
^
| template HorizonsStackInput< 3 >::MissingFiles | ||
| opengeode_geosciences_implicit_api | ||
| check_horizons_stack_missing_files< 3 >( absl::string_view ); | ||
| check_horizons_stack_missing_files< 3 >( std::string_view ); |
There was a problem hiding this comment.
warning: variable 'string_view' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
check_horizons_stack_missing_files< 3 >( std::string_view );
^| template bool opengeode_geosciences_implicit_api | ||
| is_horizons_stack_loadable< 3 >( absl::string_view ); | ||
| is_horizons_stack_loadable< 3 >( std::string_view ); |
There was a problem hiding this comment.
warning: variable 'string_view' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
is_horizons_stack_loadable< 3 >( std::string_view );
^| @@ -24,10 +24,9 @@ | |||
| #include <geode/geosciences/implicit/representation/io/horizons_stack_output.h> | |||
There was a problem hiding this comment.
warning: 'geode/geosciences/implicit/representation/io/horizons_stack_output.h' file not found [clang-diagnostic-error]
#include <geode/geosciences/implicit/representation/io/horizons_stack_output.h>
^| @@ -24,10 +24,9 @@ | |||
| #include <geode/geosciences/implicit/representation/io/horizons_stack_output.h> | |||
|
|
|||
| #include <string> | |||
| #include <string_view> | |||
| #include <vector> | |||
There was a problem hiding this comment.
warning: included header string_view is not used directly [misc-include-cleaner]
| #include <vector> | |
| #include <vector> |
| @@ -39,7 +38,7 @@ | |||
| template < index_t dimension > | |||
| std::vector< std::string > save_horizons_stack( | |||
| const HorizonsStack< dimension >& horizons_stack, | |||
There was a problem hiding this comment.
warning: 2 adjacent parameters of 'save_horizons_stack' of similar type are easily swapped by mistake [bugprone-easily-swappable-parameters]
const HorizonsStack< dimension >& horizons_stack,
^Additional context
src/geode/geosciences/implicit/representation/io/horizons_stack_output.cpp:39: the first parameter in the range is 'horizons_stack'
const HorizonsStack< dimension >& horizons_stack,
^src/geode/geosciences/implicit/representation/io/horizons_stack_output.cpp:40: the last parameter in the range is 'filename'
std::string_view filename )
^src/geode/geosciences/implicit/representation/io/horizons_stack_output.cpp:40: 'const int &' and 'int' parameters accept and bind the same kind of values
std::string_view filename )
^| @@ -24,10 +24,9 @@ | |||
| #include <geode/geosciences/implicit/representation/io/stratigraphic_model_output.h> | |||
There was a problem hiding this comment.
warning: 'geode/geosciences/implicit/representation/io/stratigraphic_model_output.h' file not found [clang-diagnostic-error]
#include <geode/geosciences/implicit/representation/io/stratigraphic_model_output.h>
^| @@ -24,10 +24,9 @@ | |||
| #include <geode/geosciences/implicit/representation/io/stratigraphic_model_output.h> | |||
|
|
|||
| #include <string> | |||
| #include <string_view> | |||
| #include <vector> | |||
There was a problem hiding this comment.
warning: included header string_view is not used directly [misc-include-cleaner]
| #include <vector> | |
| #include <vector> |
| @@ -42,7 +41,7 @@ | |||
| { | |||
| std::vector< std::string > save_stratigraphic_model( | |||
| const StratigraphicModel& stratigraphic_model, | |||
There was a problem hiding this comment.
warning: 2 adjacent parameters of 'save_stratigraphic_model' of similar type are easily swapped by mistake [bugprone-easily-swappable-parameters]
const StratigraphicModel& stratigraphic_model,
^Additional context
src/geode/geosciences/implicit/representation/io/stratigraphic_model_output.cpp:42: the first parameter in the range is 'stratigraphic_model'
const StratigraphicModel& stratigraphic_model,
^src/geode/geosciences/implicit/representation/io/stratigraphic_model_output.cpp:43: the last parameter in the range is 'filename'
std::string_view filename )
^src/geode/geosciences/implicit/representation/io/stratigraphic_model_output.cpp:43: 'const int &' and 'int' parameters accept and bind the same kind of values
std::string_view filename )
^| @@ -70,7 +69,7 @@ | |||
|
|
|||
| bool is_stratigraphic_model_saveable( | |||
| const StratigraphicModel& stratigraphic_model, | |||
There was a problem hiding this comment.
warning: 2 adjacent parameters of 'is_stratigraphic_model_saveable' of similar type are easily swapped by mistake [bugprone-easily-swappable-parameters]
const StratigraphicModel& stratigraphic_model,
^Additional context
src/geode/geosciences/implicit/representation/io/stratigraphic_model_output.cpp:70: the first parameter in the range is 'stratigraphic_model'
const StratigraphicModel& stratigraphic_model,
^src/geode/geosciences/implicit/representation/io/stratigraphic_model_output.cpp:71: the last parameter in the range is 'filename'
std::string_view filename )
^src/geode/geosciences/implicit/representation/io/stratigraphic_model_output.cpp:71: 'const int &' and 'int' parameters accept and bind the same kind of values
std::string_view filename )
^| @@ -23,8 +23,9 @@ | |||
|
|
|||
| #include <geode/geosciences/implicit/representation/io/stratigraphic_section_input.h> | |||
There was a problem hiding this comment.
warning: 'geode/geosciences/implicit/representation/io/stratigraphic_section_input.h' file not found [clang-diagnostic-error]
#include <geode/geosciences/implicit/representation/io/stratigraphic_section_input.h>
^…o-internal fix(Private): rename private folders to internal
| @@ -23,8 +23,9 @@ | |||
|
|
|||
| #include <geode/geosciences/implicit/representation/io/stratigraphic_section_input.h> | |||
|
|
|||
| #include <string_view> | |||
|
|
|||
There was a problem hiding this comment.
warning: included header string_view is not used directly [misc-include-cleaner]
| @@ -24,10 +24,9 @@ | |||
| #include <geode/geosciences/implicit/representation/io/stratigraphic_section_output.h> | |||
There was a problem hiding this comment.
warning: 'geode/geosciences/implicit/representation/io/stratigraphic_section_output.h' file not found [clang-diagnostic-error]
#include <geode/geosciences/implicit/representation/io/stratigraphic_section_output.h>
^| @@ -24,10 +24,9 @@ | |||
| #include <geode/geosciences/implicit/representation/io/stratigraphic_section_output.h> | |||
|
|
|||
| #include <string> | |||
| #include <string_view> | |||
| #include <vector> | |||
There was a problem hiding this comment.
warning: included header string_view is not used directly [misc-include-cleaner]
| #include <vector> | |
| #include <vector> |
| @@ -42,7 +41,7 @@ | |||
| { | |||
| std::vector< std::string > save_stratigraphic_section( | |||
| const StratigraphicSection& stratigraphic_section, | |||
There was a problem hiding this comment.
warning: 2 adjacent parameters of 'save_stratigraphic_section' of similar type are easily swapped by mistake [bugprone-easily-swappable-parameters]
const StratigraphicSection& stratigraphic_section,
^Additional context
src/geode/geosciences/implicit/representation/io/stratigraphic_section_output.cpp:42: the first parameter in the range is 'stratigraphic_section'
const StratigraphicSection& stratigraphic_section,
^src/geode/geosciences/implicit/representation/io/stratigraphic_section_output.cpp:43: the last parameter in the range is 'filename'
std::string_view filename )
^src/geode/geosciences/implicit/representation/io/stratigraphic_section_output.cpp:43: 'const int &' and 'int' parameters accept and bind the same kind of values
std::string_view filename )
^| @@ -70,7 +69,7 @@ | |||
|
|
|||
| bool is_stratigraphic_section_saveable( | |||
| const StratigraphicSection& stratigraphic_section, | |||
There was a problem hiding this comment.
warning: 2 adjacent parameters of 'is_stratigraphic_section_saveable' of similar type are easily swapped by mistake [bugprone-easily-swappable-parameters]
const StratigraphicSection& stratigraphic_section,
^Additional context
src/geode/geosciences/implicit/representation/io/stratigraphic_section_output.cpp:70: the first parameter in the range is 'stratigraphic_section'
const StratigraphicSection& stratigraphic_section,
^src/geode/geosciences/implicit/representation/io/stratigraphic_section_output.cpp:71: the last parameter in the range is 'filename'
std::string_view filename )
^src/geode/geosciences/implicit/representation/io/stratigraphic_section_output.cpp:71: 'const int &' and 'int' parameters accept and bind the same kind of values
std::string_view filename )
^
|
🎉 This PR is included in version 8.0.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Renaming global_epsilon to GLOBAL_EPSILON, global_angular_epsilon to GLOBAL_ANGULAR_EPSILON and all enum names (uppercase names).