Fix utf-8 char path in windows

[npes87184]

The file 'E:\安安\scrcpy-win64-v1.12.1-1-g31bd950\scrcpy-server'
exists, however, it will show msg as follow:

INFO: scrcpy 1.12.1 https://github.com/Genymobile/scrcpy
stat: No such file or directory
ERROR: 'E:\安安\scrcpy-win64-v1.12.1-1-g31bd950\scrcpy-server' does not
exist or is not a regular file
Press any key to continue...

This patch fixes it.

Signed-off-by: Yu-Chen Lin [email protected]

[rom1v]

Ah, yes, well spotted!

Thank you for the fix! 👍

[rom1v]

For command.c, there are platform-specific implementations in sys/win/ and sys/unix/.

Since the implementation is now (almost) totally different, I think the function can be moved there (without additional ifdef).

[npes87184]

OK

[npes87184]

Please see new version.

[rom1v]

Thank you.

However, I fail to make it work on Windows.

I declared the environment variable SCRCPY_SERVER_PATH (in the system preferences) to C:\Users\user\Downloads\scrcpy-win64-v1.12.1\论\scrcpy-server (where I put the file).

When I execute scrcpy.exe (built with this patch):

C:\Users/user/Downloads/scrcpy-win64-v1.12.1>scrcpy
INFO: scrcpy 1.12.1 <https://github.com/Genymobile/scrcpy>
stat: No such file or directory
ERROR: 'C:\Users\user\Downloads/scrcpy-win64-v1.12.1\?\scrcpy-server' does not exist or is not a regular file
Press any key to continue...

(If I rename 论 to some ASCII text, it works)

[npes87184]

Thank you for your testing.

There are two problems here.

1. The path sent to is_regular_file does not handle non-ascii.
2. The env variable needs to consider non-ascii case.

I have a computer which will get absolute path from get_server_path, if the path contains non-ascii text, it will failed to stat, this problem fixed by 71db667.

However, if I set env variable as your testing method, it does not work again. After digging on it, I found the problem is due to the getenv. This problem fixed by 2639c6a.

Thanks.

[rom1v]

Oh thank you 👍

There was a problem with get_server_path(), which sometimes returned an allocated string, sometimes not. I fixed it beforehand: 7d58451

Then I rebased your commit and edited the last one. Please review pr1002 (and test it if you can, I did my own tests, but I'm not sure they are exhaustive).

[npes87184]

I have tested on my computer, everything works!
Also, the patches look good to me.

Thank you.

[rom1v]

👍 Thank you very much.

Merged into dev.

[rom1v]

Released in v1.13.