fix(chen2021Fitness): don't hand out invalid JSON when there are not enough data to compute a fit #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some values were NaN or Infinity, which are no valid JSON tokens. Instead throw an error.
resolves #41
This PR tries to be minimally invasive, as this repo is mostly in maintenance mode. I only added what is necessary to fix the issue. As this repo has no test coverage, I don't want to risk more than necessary.
How I tested this locally:
requirements.txt
looks as follows:MODEL_ENDPOINT = "http://localhost:7070"
cov-spectrum-server/src/main/kotlin/ch/ethz/covspectrum/controller/Chen2021FitnessController.kt
Line 15 in f981d5a
COV_SPECTRUM_DB_USERNAME=dummy;COV_SPECTRUM_DB_PASSWORD=dummy;COV_SPECTRUM_JWT_TOKEN_LIFETIME_SECONDS=10
cov-spectrum-server/src/main/kotlin/ch/ethz/covspectrum/CovSpectrumServerApplication.kt
Lines 15 to 16 in f981d5a