Skip to content

No dataFormat arguments for  sample/aminoAcidMutations but sample/nuclotideMutations Endpoint – inconsistent ? #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gordonkoehn opened this issue Apr 22, 2025 · 2 comments · Fixed by #1160, #1161 or loculus-project/loculus#4094
Closed

No dataFormat arguments for  sample/aminoAcidMutations but sample/nuclotideMutations Endpoint – inconsistent ? #1159

gordonkoehn opened this issue Apr 22, 2025 · 2 comments · Fixed by #1160, #1161 or loculus-project/loculus#4094
Assignees
@fengelniederhammer

Comments

@gordonkoehn
Copy link

The CovSpectrum API seems to have slightly differing arguments for the endpoints sample/aminoAcidMutations and sample/nuclotideMutations.

There is the argument dataFormat for the latter only. It is not obvious to me if this is by intend or accidental. At least is was suprising there was a difference to me when using.

API Version: v2

Issue also consulted with @Taepper.

See the screenshots below:

Image
Image
@gordonkoehn gordonkoehn changed the title No dataFormat arguments for  sample/aminoAcidMutations but sample/nuclotideMutations Endpoint – inconsistent ? No dataFormat arguments for  sample/aminoAcidMutations but sample/nuclotideMutations Endpoint – inconsistent ? Apr 22, 2025
@fengelniederhammer fengelniederhammer self-assigned this Apr 22, 2025
@fengelniederhammer
Copy link
Contributor

Thanks for finding this. It's indeed missing in the docs, but it should work correctly nonetheless.

@fengelniederhammer fengelniederhammer transferred this issue from GenSpectrum/LAPIS-SILO Apr 22, 2025
fengelniederhammer added a commit that referenced this issue Apr 22, 2025
@fengelniederhammer
fix(lapis): add missing dataFormat to amino acid mutation GET endpo…
6369eef 
…int in Swagger UI

rseolves #1159
fengelniederhammer added a commit that referenced this issue Apr 22, 2025
@fengelniederhammer
fix(lapis): add missing dataFormat to amino acid mutation GET endpo…
66f1b1a 
…int in Swagger UI

resolves #1159
@fengelniederhammer fengelniederhammer mentioned this issue Apr 22, 2025
Merged
1 task
fengelniederhammer added a commit that referenced this issue Apr 22, 2025
@fengelniederhammer
fix(lapis): add missing dataFormat to amino acid mutation GET endpo…
26a9604 
…int in Swagger UI

resolves #1159
@gordonkoehn
Copy link
Author

Hi Fabian, yes indeed it does work just fine. Blitz-patch indeed – Thanks.

This was referenced Apr 22, 2025
Merged
Merged
@chaoran-chen chaoran-chen mentioned this issue May 11, 2025
Merged
This was referenced May 15, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengelniederhammer fengelniederhammer

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gordonkoehn @fengelniederhammer