Skip to content

Upper bounds, CI, badges #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 21, 2023
Merged

Upper bounds, CI, badges #79

merged 7 commits into from
Nov 21, 2023

Conversation

sorki
Copy link
Collaborator

@sorki sorki commented Nov 12, 2023

in similar fashion and related to Gabriella439/Haskell-Nix-Derivation-Library#22

dhall.ci was removed in favor of Garnix which was then removed and only ci.yaml was reintroduced (with added nix-build, which is now also available in haskell-ci.dhall as a simple withNix combinator)

Marking as draft until we resolve nix-derivation.

@Gabriella439
Copy link
Owner

The matching PR for nix-derivation is merged and published to Hackage now, so this one should be good to go now.

sorki added a commit to sorki/nix-diff that referenced this pull request Nov 20, 2023
Most imporant one is allowing newer `unix-2.8.3.0` which otherwise prevents
dependency resolution.
@sorki sorki marked this pull request as ready for review November 20, 2023 07:22
@sorki
Copy link
Collaborator Author

sorki commented Nov 20, 2023

I might be able to resolve the dontCheck as well after I extract stubbed store testing harness from hnix-store-remote into hnix-store-tests.

@sorki
Copy link
Collaborator Author

sorki commented Nov 20, 2023

I'm scared of the Squash and merge button 😸

@sorki
Copy link
Collaborator Author

sorki commented Nov 20, 2023

Think it's fine to squash all this just got me wondering if I should I create separate PRs instead for future stuff (and I should of course if the things are not quite related) and if this also automatically adds the PR ID to the commit message(s).

@Gabriella439
Copy link
Owner

I can change the repo to support other merge methods. I'll do that right now

@sorki sorki merged commit 872cac9 into Gabriella439:main Nov 21, 2023
@sorki
Copy link
Collaborator Author

sorki commented Nov 21, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants