Skip to content

Remove unlawful ArrowChoice instance #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

Topsii
Copy link
Collaborator

@Topsii Topsii commented Jan 4, 2025

*> L1.fold1 (arr $ left id) (Right 10 :| [Left 200 :: Either Int Int])                     
Left 200
*> L1.fold1 (left $ arr id) (Right 10 :| [Left 200 :: Either Int Int]) 
Right 10

violates the ArrowChoice law that left (arr f) = arr (left f).

When I added this instance in #215 I was trusting that the ArrowChoice instance that already existed in the folds package was correct. I apologize for any inconvenience.

@Topsii Topsii force-pushed the remove-arrowchoice branch from ef74c23 to cd7c057 Compare January 4, 2025 15:17
@Gabriella439
Copy link
Owner

No worries!

@Gabriella439 Gabriella439 merged commit c0a013e into Gabriella439:main Jan 4, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants