Add FoldM1 #219
Open
Add FoldM1 #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Topsii
force-pushed
the
foldm1
branch
3 times, most recently
from
095f66c to
49b9b86
Compare
Gabriella439
approved these changes
Jan 4, 2025
src/Control/Foldl/NonEmpty.hs
Outdated
| @@ -375,16 +601,77 @@ minimumBy cmp = Fold1 (\begin -> Fold min' begin id) | |||
| _ -> x | |||
| {-# INLINABLE minimumBy #-} | |||
|
|
|||
| -- | Upgrade a fold to accept the 'Fold1' type | |||
| -- | Upgrade a "non-empty" fold to accept the 'Fold1' type | |||
There was a problem hiding this comment.
I think you want to escape quotes, otherwise haddock tries to interpret them as a module reference. Same comment for the other quotes in the documentation:
Suggested change
| -- | Upgrade a "non-empty" fold to accept the 'Fold1' type | |
| -- | Upgrade a \"non-empty\" fold to accept the 'Fold1' type |
Topsii
force-pushed
the
foldm1
branch
2 times, most recently
from
a902c0c to
67c7826
Compare
With background shading the rounded corners between two immediately consecutive inline code spans would be visible. Merges these inline code spans into a single one to avoid this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not export the constructor
FoldM1'. Instead I export the pattern synonymFoldM1, which has a Monad constraint. This way we retain the option to later change the datatype definition toNote that currently
hoistsor the Functor instance can only be implemented withFoldM1'because they do not requireMonad m.I also changed the handler type signatures from
Handler a btoHandler s ato match thes t a bnaming scheme for optics.