Skip to content

Added Toggle Button #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Added Toggle Button #7

wants to merge 10 commits into from

Conversation

Taskeren
Copy link
Member

@Taskeren Taskeren commented May 19, 2025

Added a Disable Toggle Button for Default Server List, so that people like me can disable this mod with only 1 click.

This is for people like me who don't like this mod (because we host our own server), but also don't like or is forgetful to remove this mod.

image

image

@Taskeren Taskeren requested a review from a team May 19, 2025 13:03
@Taskeren Taskeren added the enhancement New feature or request label May 19, 2025
@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label May 19, 2025
@Taskeren Taskeren changed the title Added Disable Button Added Toggle Button May 19, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need to be a mixin. You can use the various subclasses of GuiScreenEvent.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This make private and protected things available. Otherwise, I'll have to do reflection or mixin accessors.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use an Access Transformer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use the JSON format. If you want to replace MixinPlugin, implement IEarlyMixinLoader. This gives us more freedom in the future.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use the JSON format. If you want to replace MixinPlugin, implement IEarlyMixinLoader. This gives us more freedom in the future.

Why not to do so when there is a need?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use the same system for every mod. This makes maintaining the mods easier because you know what to expect.

@Taskeren Taskeren requested a review from glowredman May 21, 2025 08:50
Copy link

#8

@Taskeren
Copy link
Member Author

Taskeren commented May 22, 2025

Fine, I gave up on this.

I've never known the proper way to do the early mixin, so does this time.
I don't know why it doesn't work, and there is nowhere to find the answer.

Hope somebody can take on this and make it work, I do need this feature but it is out of my ability.

Also the *** **** "No SRG name found"

@Taskeren Taskeren closed this May 22, 2025
@Dream-Master Dream-Master deleted the feature/disable-button branch May 23, 2025 08:38
@serenibyss serenibyss removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants