-
Notifications
You must be signed in to change notification settings - Fork 1
Added Toggle Button #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't need to be a mixin. You can use the various subclasses of GuiScreenEvent
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This make private and protected things available. Otherwise, I'll have to do reflection or mixin accessors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use an Access Transformer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use the JSON format. If you want to replace MixinPlugin
, implement IEarlyMixinLoader
. This gives us more freedom in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use the JSON format. If you want to replace
MixinPlugin
, implementIEarlyMixinLoader
. This gives us more freedom in the future.
Why not to do so when there is a need?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use the same system for every mod. This makes maintaining the mods easier because you know what to expect.
…ture/disable-button # Conflicts: # src/main/java/glowredman/defaultserverlist/EarlyMixinPlugin.java
Fine, I gave up on this. I've never known the proper way to do the early mixin, so does this time. Hope somebody can take on this and make it work, I do need this feature but it is out of my ability. Also the *** **** "No SRG name found" |
Added a
DisableToggle Button for Default Server List, so that people like me can disable this mod with only 1 click.This is for people like me who don't like this mod (because we host our own server), but also don't like or is forgetful to remove this mod.