-
Notifications
You must be signed in to change notification settings - Fork 4
Refactor sites methods/attrs into other classes #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@v1kko Could you review this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So many movements and name changes, but overall everything seems to be in order, I left some small comments, but otherwise I think it is good to go
Co-authored-by: Victor Azizi <[email protected]>
Co-authored-by: Victor Azizi <[email protected]>
There is a remaining issue that the rdf is not calculated correctly. It needs the full trajectory. When passing transitions, it just calculates RDF for 'Li'. |
This PR removes the SitesData class and moves all its methods/attributes to other classes.
Closes #240
Todo
.n_floating
returns the wrong number #252structure
->sites
on Jumps/Transitions now that name clash with SitesData is no longer an issue