Cherry picks from GIN DOI changes #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a fix for constructing the URL query for triggering the DOI request. Some parts of the string weren't being (un)escaped properly. |
Minor changes to comments and descriptions in the datacite.yml file template. DType renamed to ResourceType. References can be other kinds of identifiers, not just DOI (arXiv and PubMed ID supported).
Renamed DOI configuration variables and structs to avoid stuttering: Doi.DoiUrl -> DOI.URL Doi.DoiKey -> DOI.Key etc
The original loop breaks after finding a readme file, so if the readme is found before the datacite, the loop breaks and the datacite is never found. We could modify it so that it keeps running until the end, but I don't want to make bigger changes to the existing upstream code. It would also change the behaviour when there are multiple files that are detected as README files (which is a separate issue).
achilleas-k
force-pushed
the
gin-doi-cherry-picks
branch
from
1c2f62c to
56c627f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked commits from #42 and #43 and resolved conflicts for rebased branch.