Support custom commit messages #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New commit flag "message" (or "m" for short form) for setting a commit message.
mpsonntag
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New commit flag "message" (or "m" for short form) can be used to set a custom commit message.
The automatic commit message includes a summary of the changes being committed (files added, removed, modified). If this new flag is used, only the commit message specified is added. Do you think it should add the summary as the message body?
I'm also considering going back to listing the files that were affected. It used to do this, but I removed it thinking it might be an issue when the file list is too large. This doesn't seem to be a common phenomenon and even in that case, we could print the filenames affected up to a certain number (or text length).