Skip to content

Stabilize ABI errors #7241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 23, 2025
Merged

Stabilize ABI errors #7241

merged 7 commits into from
Jun 23, 2025

Conversation

IGI-111
Copy link
Contributor

@IGI-111 IGI-111 commented Jun 19, 2025

Description

Stabilize the error_type feature.
Fixes #6765

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@IGI-111 IGI-111 temporarily deployed to fuel-sway-bot June 19, 2025 18:43 — with GitHub Actions Inactive
Copy link

codspeed-hq bot commented Jun 19, 2025

CodSpeed Performance Report

Merging #7241 will not alter performance

Comparing IGI-111/abi_errors (a8cb65d) with master (1ac3514)

Summary

✅ 24 untouched benchmarks

@IGI-111 IGI-111 force-pushed the IGI-111/abi_errors branch from 83ca50a to 3590c0e Compare June 19, 2025 21:04
@IGI-111 IGI-111 temporarily deployed to fuel-sway-bot June 19, 2025 21:04 — with GitHub Actions Inactive
@IGI-111 IGI-111 force-pushed the IGI-111/abi_errors branch from 3590c0e to 90eda24 Compare June 19, 2025 23:37
@IGI-111 IGI-111 temporarily deployed to fuel-sway-bot June 19, 2025 23:37 — with GitHub Actions Inactive
@IGI-111 IGI-111 force-pushed the IGI-111/abi_errors branch from 90eda24 to 76976ab Compare June 20, 2025 17:03
@IGI-111 IGI-111 temporarily deployed to fuel-sway-bot June 20, 2025 17:03 — with GitHub Actions Inactive
Stabilize the `error_type` feature.
Fixes #6765
@IGI-111 IGI-111 force-pushed the IGI-111/abi_errors branch from 76976ab to f4534f0 Compare June 21, 2025 03:10
@IGI-111 IGI-111 temporarily deployed to fuel-sway-bot June 21, 2025 03:10 — with GitHub Actions Inactive
@IGI-111 IGI-111 added the breaking May cause existing user code to break. Requires a minor or major release. label Jun 21, 2025
@IGI-111 IGI-111 marked this pull request as ready for review June 21, 2025 04:25
@IGI-111 IGI-111 requested review from a team as code owners June 21, 2025 04:25
Copy link
Member

@ironcev ironcev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this over @IGI-111! It's always quite some repetitive work to promote an experimental feature.

Co-authored-by: Igor Rončević <[email protected]>
@IGI-111 IGI-111 temporarily deployed to fuel-sway-bot June 23, 2025 05:45 — with GitHub Actions Inactive
@IGI-111 IGI-111 requested a review from ironcev June 23, 2025 06:18
@IGI-111 IGI-111 temporarily deployed to fuel-sway-bot June 23, 2025 06:18 — with GitHub Actions Inactive
ironcev
ironcev previously approved these changes Jun 23, 2025
JoshuaBatty
JoshuaBatty previously approved these changes Jun 23, 2025
@IGI-111 IGI-111 enabled auto-merge (squash) June 23, 2025 09:06
@IGI-111 IGI-111 temporarily deployed to fuel-sway-bot June 23, 2025 09:06 — with GitHub Actions Inactive
@IGI-111 IGI-111 dismissed stale reviews from ironcev and JoshuaBatty via a8cb65d June 23, 2025 09:32
@IGI-111 IGI-111 temporarily deployed to fuel-sway-bot June 23, 2025 09:32 — with GitHub Actions Inactive
@IGI-111 IGI-111 requested review from ironcev and JoshuaBatty June 23, 2025 09:32
@IGI-111 IGI-111 merged commit 5064247 into master Jun 23, 2025
41 checks passed
@IGI-111 IGI-111 deleted the IGI-111/abi_errors branch June 23, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking May cause existing user code to break. Requires a minor or major release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error type
4 participants